-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support structured logging (KV) #77
Draft
SpriteOvO
wants to merge
10
commits into
main-dev
Choose a base branch
from
kv
base: main-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e4df18
to
07d7b08
Compare
247c760
to
1b83657
Compare
402e880
to
ea77c85
Compare
1a8f5da
to
c7f733a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #70, working in progress.
Steps
kv::Key
andkv::Value
value-bag
directly (alias) for value first.kvs
field tostruct Record
.kv
optional parameter.kv
is optional, just like the existinglogger
argument, and I may wish to allow them to be in any order. The colon allows us to distinguish with the formatting arguments so that it can be placed anywhere.FullFormatter
.PatternFormatter
.{kv}
pattern to output like"{ k1=1, k2=text }"
kv
field inJsonFormatter
.phf
map for KV. (self-reminder: benchmarking it..)phf
only supports limited types for key (doc), and we have a custom typekv::Key
, so abandon the idea.Record
, downcasting, etc.).